.dockerignore: ignore unnecessary repo files#54
Merged
ee7 merged 1 commit intoexercism:mainfrom Aug 7, 2023
Merged
Conversation
On the penultimate line of our Dockerfile we have the instruction:
COPY . .
which previously copied some small unneeded repo files into the images.
Add them to the ignore list so that they are no longer copied.
With this commit, the /opt/test-runner directory in the image contains
only this file:
/opt/test-runner/bin/run.sh
Refs: exercism#34
ee7
commented
Aug 6, 2023
ErikSchierboom
approved these changes
Aug 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the penultimate line of our Dockerfile we have the instruction:
zig-test-runner/Dockerfile
Line 28 in f7cfede
which previously copied some small unneeded repo files into the images. Add them to the ignore list so that they are no longer copied.
With this commit, the
/opt/test-runner directoryin the image contains only/opt/test-runner/bin/run.sh.We could instead change that
COPYinstruction to copy that specific file, but let's stick with the.dockerignoreapproach for now.Refs: #34 (to a tiny extent)