exercises(queen-attack): remove input validation tests#335
Open
ee7 wants to merge 8 commits intoexercism:mainfrom
Open
exercises(queen-attack): remove input validation tests#335ee7 wants to merge 8 commits intoexercism:mainfrom
ee7 wants to merge 8 commits intoexercism:mainfrom
Conversation
Make it self-documenting that the valid values are greater than equal to 0 and less than 8.
1 task
booniepepper
approved these changes
Oct 4, 2023
keiravillekode
approved these changes
Jan 29, 2025
kotp
requested changes
Feb 1, 2025
Member
kotp
left a comment
kotp
left a comment
There was a problem hiding this comment.
I know this is an old patch, but I am happy to approve once the conflict is resolved, if this is still the direction we want to go (no error handling).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
QueenErrorand the input validation tests. They weren't interesting - there's no good reason forinitparams to bei8when the valid range is between 0 and 7 inclusive.This PR will break everybody's solution, but I think that's worthwhile.
Closes: #223
Refs: #229
To-do:
.appendfile that explains how toassert