Skip to content

Exposes channel:delete as command#3150

Merged
jonsamp merged 1 commit intomainfrom
jon/eng-17122-add-channeldelete-to-eas-cli-help
Aug 25, 2025
Merged

Exposes channel:delete as command#3150
jonsamp merged 1 commit intomainfrom
jon/eng-17122-add-channeldelete-to-eas-cli-help

Conversation

@jonsamp
Copy link
Copy Markdown
Member

@jonsamp jonsamp commented Aug 22, 2025

Why

Had a user who wanted to delete some channels, but didn't know about the delete command due to it being hidden. This PR exposes it.

Test Plan

Make sure that when you run easd channel --help, you see the delete command.

Screenshot 2025-08-22 at 2 52 27 PM

@linear
Copy link
Copy Markdown

linear bot commented Aug 22, 2025

@jonsamp jonsamp requested a review from wschurman August 22, 2025 19:53
@github-actions
Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @douglowder
packages/eas-cli/src/commands/channel/** @wschurman, @quinlanj

Generated by CodeMention

@jonsamp jonsamp added the no changelog PR that doesn't require a changelog entry label Aug 22, 2025
@github-actions
Copy link
Copy Markdown

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

@github-actions
Copy link
Copy Markdown

Size Change: -1.99 kB (0%)

Total Size: 53.6 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.6 MB -1.99 kB (0%)

compressed-size-action

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.89%. Comparing base (3784745) to head (2c423c5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3150      +/-   ##
==========================================
- Coverage   51.90%   51.89%   -0.00%     
==========================================
  Files         616      616              
  Lines       24850    24849       -1     
  Branches     5225     5225              
==========================================
- Hits        12895    12894       -1     
  Misses      10883    10883              
  Partials     1072     1072              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jonsamp jonsamp merged commit f094146 into main Aug 25, 2025
11 of 12 checks passed
@jonsamp jonsamp deleted the jon/eng-17122-add-channeldelete-to-eas-cli-help branch August 25, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog PR that doesn't require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants