Skip to content

[ENG-17987][eas-cli] delete branch in background#3258

Merged
quinlanj merged 2 commits intomainfrom
11-14-_eas-cli_delete_branch_in_background
Nov 19, 2025
Merged

[ENG-17987][eas-cli] delete branch in background#3258
quinlanj merged 2 commits intomainfrom
11-14-_eas-cli_delete_branch_in_background

Conversation

@quinlanj
Copy link
Copy Markdown
Member

@quinlanj quinlanj commented Nov 14, 2025

Why

Add support for deleting EAS branches and their updates in the background. Previously, branch deletion was done synchronously, which could lead to timeouts or failures when deleting branches with many updates. This change implements a background job approach for branch deletion to improve reliability.

How

  • Added a new GraphQL mutation scheduleUpdateBranchDeletion that creates a background job for branch deletion
  • Created a new utility function scheduleBranchDeletionAsync in a new file branch/delete.ts
  • Updated the branch delete command to use the background job approach instead of the synchronous deletion
  • Added polling for the background job completion using pollForBackgroundJobReceiptAsync
  • Updated GraphQL schema with new types for branch deletion and workflow insights

Test Plan

  • Create a branch with EXPO_DEBUG=1 eas-dev branch:create
  • delete branch with: EXPO_DEBUG=1 eas-dev branch:delete, ensure successful receipt
  • ensure successful deletion: eas-dev branch:list, make sure branch we just deleted is absent

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@quinlanj quinlanj changed the title [eas-cli] delete branch in background [ENG-17987][eas-cli] delete branch in background Nov 14, 2025
@linear
Copy link
Copy Markdown

linear bot commented Nov 14, 2025

@quinlanj quinlanj requested a review from wschurman November 14, 2025 23:59
@quinlanj quinlanj marked this pull request as ready for review November 14, 2025 23:59
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 14, 2025

Size Change: -1.37 kB (0%)

Total Size: 54.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 54.9 MB -1.37 kB (0%)

compressed-size-action

@github-actions
Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 15, 2025

Codecov Report

❌ Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.91%. Comparing base (dead119) to head (14ac9c1).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/branch/delete.ts 33.34% 4 Missing ⚠️
packages/eas-cli/src/branch/delete.ts 57.15% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3258      +/-   ##
==========================================
+ Coverage   51.89%   51.91%   +0.02%     
==========================================
  Files         631      632       +1     
  Lines       25860    25872      +12     
  Branches     5435     5436       +1     
==========================================
+ Hits        13418    13428      +10     
- Misses      11323    11325       +2     
  Partials     1119     1119              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@quinlanj quinlanj force-pushed the 11-14-_eas-cli_delete_branch_in_background branch from aa83807 to 14ac9c1 Compare November 19, 2025 00:28
@github-actions
Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

@quinlanj quinlanj merged commit 37ca2eb into main Nov 19, 2025
11 checks passed
@quinlanj quinlanj deleted the 11-14-_eas-cli_delete_branch_in_background branch November 19, 2025 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants