[eas-cli] Fix usage warning bug in eas:build#3260
Merged
Conversation
mackenco
commented
Nov 17, 2025
| env, | ||
| }); | ||
|
|
||
| if (!hasWarnedAboutUsageOverages && !flags.localBuildOptions.localBuildMode) { |
Contributor
Author
There was a problem hiding this comment.
This this function could run multiple times (per build profile), we want to track if we've warned and only do it once.
|
Subscribed to pull request
Generated by CodeMention |
|
Size Change: +37 B (0%) Total Size: 54.9 MB
|
|
✅ Thank you for adding the changelog entry! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3260 +/- ##
==========================================
- Coverage 51.89% 51.88% -0.00%
==========================================
Files 631 631
Lines 25860 25862 +2
Branches 5435 5437 +2
==========================================
- Hits 13418 13417 -1
- Misses 11323 11325 +2
- Partials 1119 1120 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
douglowder
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Received a bug report that the
eas:buildcommand was failing on latest. We were checking the project config too early.How
Moved the
maybeWarnAboutUsageOveragesAsynccall later into the command; now it's called inprepareAndStartBuildAsync, after we know we have a config. I put it early in this function because 1) I wanted to warn before we start the build 2) I wanted it to come before most of the other info logged by the command but 3) aftercreateBuildContextAsyncis run, since this grabs theaccountId.Test Plan
I overrode the logic in

maybeWarnAboutUsageOveragesAsyncto always warn locally. I think it's a little odd that it comes after the incremented log, but felt like a logical place in the code for this to live.Multiple builds:
Single build:
