Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3578 +/- ##
==========================================
+ Coverage 54.27% 54.35% +0.08%
==========================================
Files 820 822 +2
Lines 35055 35201 +146
Branches 7260 7283 +23
==========================================
+ Hits 19024 19129 +105
- Misses 15944 15985 +41
Partials 87 87 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f0add14 to
97d7b65
Compare
Signed-off-by: Ash Wu <hsatac@gmail.com>
97d7b65 to
ceafe48
Compare
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
|
Subscribed to pull request
Generated by CodeMention |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
iOS builds currently have no visibility into per-module compile timing. Developers can't easily identify which targets are slow. Xcode generates
.xcactivitylogfiles with detailed build timing data, but since Xcode 11 the CLI (xcodebuild) only produces them when-resultBundlePathis provided — which our Fastlane templates didn't include.Linear: ENG-20491
How
result_bundle(true)andresult_bundle_pathto both Gymfile templates (archive + simulator) to trigger xcactivitylog generation. Also addderived_data_pathto the archive template so the xcactivitylog lands in a known location (ios/build).parseAndReportXcactivitylog()utility that downloads a pre-built XCLogParser binary, parses the xcactivitylog into JSON, and logs a per-module compile metrics table. Never fails the build — all errors are caught and logged as warnings.eas/parse_xcactivitylogas a built-in step function (opt-in for custom workflows).parseAndReportXcactivitylog()in the traditional iOS builder flow under a newPARSE_XCACTIVITYLOGbuild phase, gated behindEXPERIMENTAL_EAS_XCACTIVITYLOG=1env var.PARSE_XCACTIVITYLOGto theBuildPhaseenum in@expo/eas-build-job(requires publishing a new version and updating the dependency in universe for the display name to render correctly on the website).Test Plan
EXPERIMENTAL_EAS_XCACTIVITYLOG=1in build profile env