[build-tools] early stop android emum when not nested virtualization#3580
Open
[build-tools] early stop android emum when not nested virtualization#3580
Conversation
… emulator when not on nested virtualization enabled host
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3580 +/- ##
==========================================
+ Coverage 54.27% 54.29% +0.02%
==========================================
Files 820 820
Lines 35055 35068 +13
Branches 7260 7262 +2
==========================================
+ Hits 19024 19037 +13
Misses 15944 15944
Partials 87 87 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
Align Android emulator nested-virtualization detection with step runtime metadata instead of Node process platform, and expand tests to assert early failure on non-Linux runtime platforms.
Return a typed user-facing error when Android emulator virtualization requirements are not met so this early-stop path avoids noisy unknown-error stack output.
|
Subscribed to pull request
Generated by CodeMention |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
packages/build-tools/src/steps/functions/startAndroidEmulator.ts
Outdated
Show resolved
Hide resolved
|
✅ Thank you for adding the changelog entry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Needing nested virtualization detection at function
start_android_emulatorfor improved error message/fast-fail whenever not in nested virtualization enabled vm.How
By doing an early check on start-android-emulator function for VMX/SVM enabled CPU and displaying user friendly error message, which guides user towards solution.
Test Plan
grep -Eq '(vmx|svm)' /proc/cpuinfo; echo $?on VMX enabled CPU to confirm status0Ref ENG-17446