Node AsyncLocalStorage destroyed/lost when multer 1.4.4-lts.1 or later is used

[C-Saunders]

I made a simple Express app that demonstrates the problem: https://github.com/C-Saunders/multer-test

AsyncLocalStorage docs for reference

It's possible this is an issue with busboy, rather than multer. I didn't attempt to use different busboy versions because there were breaking changes between the versions used by these versions of multer, but it might be possible to untangle these.

[LinusU]

It would be great if you could test this using only Busboy, as you say it's probably an issue that could be fixed there 👍

[C-Saunders]

@LinusU I've updated the repo linked in the issue to include an endpoint that uses Busboy. It didn't reproduce this issue, so I figure either there's something in Multer that's the issue, or I didn't use Busboy close enough to how Multer uses it to reproduce the issue.

[cperfect]

Same issue as #814 ? Anyway solution there seems to work for my case.

[finnp]

I think somewhere in Multer something like this happens:

server.post(
	"/busboy-middleware",
	(req: Request, res: Response, next: NextFunction) => {
		// busboy middleware logic
		const bb = busboy({ headers: req.headers });
		bb.on("field", (name, val, _info) => {
			console.log(`Field [${name}]: value: %j`, val);
		});
		bb.on(
			"close",
		          () => {
				console.log("Done parsing form!");
				next();
			},
		);
		req.pipe(bb);
	},
	(req: Request, res: Response, _next: NextFunction) => {
		return res.send(`Context: ${executionContext.getStore()}`);
	},
);

And something like this

			"close",
			AsyncResource.bind(() => {
				console.log("Done parsing form!");
				next();
			}),
		);

would be needed to not loose the context after the close event.