build: enable IP_BOUND_IF outbound binding on iOS#492
Open
BoringApp wants to merge 1 commit into
Open
Conversation
Upstream's #[cfg(target_os = "macos")] gates on the IP_BOUND_IF setsockopt path (and supporting imports/traits) exclude iOS, even though iOS shares the Darwin kernel and supports IP_BOUND_IF identically. iOS targets fall through to the catch-all and return "binding to interface is not supported on this platform" at runtime. Extend the cfg sets to include target_os = "ios" in: - CString / AsRawFd imports - trait BindSocket (and its fallback definition) - the setsockopt(IP_BOUND_IF) call site - the unreachable error branch Also add libc as a dependency for the ios target (previously only gated for macos + linux). Verified on iPhone via NEPacketTunnelProvider: OUTBOUND_INTERFACE= pdp_ip0 setenv before leaf_run, leaf logs "socket bind pdp_ip0" and outbound TCP/UDP correctly egress over the cellular interface without going back into the tun.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream's #[cfg(target_os = "macos")] gates on the IP_BOUND_IF setsockopt path (and supporting imports/traits) exclude iOS, even though iOS shares the Darwin kernel and supports IP_BOUND_IF identically. iOS targets fall through to the catch-all and return "binding to interface is not supported on this platform" at runtime.
Extend the cfg sets to include target_os = "ios" in:
Also add libc as a dependency for the ios target (previously only gated for macos + linux).
Verified on iPhone via NEPacketTunnelProvider: OUTBOUND_INTERFACE= pdp_ip0 setenv before leaf_run, leaf logs "socket bind pdp_ip0" and outbound TCP/UDP correctly egress over the cellular interface without going back into the tun.