Skip to content

Fix HIGH-level code scanning alerts: DOM XSS and unvalidated URL redirect #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix HIGH-level code scanning alerts: DOM XSS and unvalidated URL redirect #480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f340112
Fix HIGH-level code scanning alerts: DOM XSS and unvalidated URL redi…
Copilot Apr 17, 2026
75c3197
Strengthen URL validation to block protocol-relative URLs in dropdown…
Copilot Apr 17, 2026
00ac26a
Update admin_interface/static/admin_interface/dropdown-filter/dropdow…
fabiocaccamo Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions admin_interface/static/admin_interface/dropdown-filter/dropdown-filter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,20 @@
document.querySelectorAll('.list-filter-dropdown select').forEach(select => {
select.addEventListener('change', (event) => {
const value = event.target.value;
if (value) {
window.location = value;
if (!value) {
return;
}

try {
const url = new URL(value, window.location.href);
if (
(url.protocol === 'http:' || url.protocol === 'https:') &&
url.origin === window.location.origin
) {
window.location = url.href;
}
} catch (error) {
// Ignore invalid URLs.
}
});
});
Expand Down
12 changes: 7 additions & 5 deletions admin_interface/static/admin_interface/related-modal/related-modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,13 @@ if (typeof(django) !== 'undefined' && typeof(django.jQuery) !== 'undefined') {
// fix for django 1.7 TODO remove
iframeSrc = updateURLParameter(iframeSrc, '_popup', '1');

// build the iframe html
const iframeHTML = '<iframe id="related-modal-iframe" name="' + iframeName + '" src="' + iframeSrc + '"></iframe>';
const modalHTML = '<div class="related-modal-iframe-container">' + iframeHTML + '</div>';
const modalEl = $(modalHTML);
const iframeEl = modalEl.find('#related-modal-iframe');
// build the iframe using DOM API to avoid XSS via string concatenation
const iframeEl = $('<iframe>').attr({
id: 'related-modal-iframe',
name: iframeName,
src: iframeSrc,
});
const modalEl = $('<div>').addClass('related-modal-iframe-container').append(iframeEl);

if (e.data.lookup === true) {
// set current window as iframe opener because
Expand Down
Loading
⚡