Build fails on master/last release tag

[strarsis]

I try to build fabio from source but it fails on master and on the last release tag (v1.0.7).

Steps to (probably) reproduce this:

$ git clone https://github.com/eBay/fabio.git
$ cd fabio

$ git checkout v1.0.7
$ git reset --hard

$ export GOPATH=$(pwd) # is set!

$ go get github.com/eBay/fabio

During go get I get this error:

[...]
src/github.com/eBay/fabio/route/table.go:15: undefined: atomic.Value
[...]

When I don't run go get, and directly go build, I get the error that it cannot find sources,
hence I run go get first to fix this:

$ go build

main.go:10:2: cannot find package "github.com/eBay/fabio/admin" in any of:
        /usr/lib/go/src/pkg/github.com/eBay/fabio/admin (from $GOROOT)
        /home/build/src/fabio/src/github.com/eBay/fabio/admin (from $GOPATH)
init.go:10:2: cannot find package "github.com/eBay/fabio/config" in any of:
        /usr/lib/go/src/pkg/github.com/eBay/fabio/config (from $GOROOT)
        /home/build/src/fabio/src/github.com/eBay/fabio/config (from $GOPATH)
listen.go:16:2: cannot find package "github.com/eBay/fabio/exit" in any of:
        /usr/lib/go/src/pkg/github.com/eBay/fabio/exit (from $GOROOT)
        /home/build/src/fabio/src/github.com/eBay/fabio/exit (from $GOPATH)
init.go:11:2: cannot find package "github.com/eBay/fabio/metrics" in any of:
        /usr/lib/go/src/pkg/github.com/eBay/fabio/metrics (from $GOROOT)
        /home/build/src/fabio/src/github.com/eBay/fabio/metrics (from $GOPATH)
listen.go:17:2: cannot find package "github.com/eBay/fabio/proxy" in any of:
        /usr/lib/go/src/pkg/github.com/eBay/fabio/proxy (from $GOROOT)
        /home/build/src/fabio/src/github.com/eBay/fabio/proxy (from $GOPATH)
init.go:12:2: cannot find package "github.com/eBay/fabio/registry" in any of:
        /usr/lib/go/src/pkg/github.com/eBay/fabio/registry (from $GOROOT)
        /home/build/src/fabio/src/github.com/eBay/fabio/registry (from $GOPATH)
init.go:13:2: cannot find package "github.com/eBay/fabio/registry/consul" in any of:
        /usr/lib/go/src/pkg/github.com/eBay/fabio/registry/consul (from $GOROOT)
        /home/build/src/fabio/src/github.com/eBay/fabio/registry/consul (from $GOPATH)
init.go:14:2: cannot find package "github.com/eBay/fabio/route" in any of:
        /usr/lib/go/src/pkg/github.com/eBay/fabio/route (from $GOROOT)
        /home/build/src/fabio/src/github.com/eBay/fabio/route (from $GOPATH)

Also when running go build after go get:

[...]
$ go build
[...]

Same error message:

[...]
src/github.com/eBay/fabio/route/table.go:15: undefined: atomic.Value
[...]

No fabio binary is created.

Using go version go1.3.3 linux/amd64) from Debian Jessie stable.

[magiconair]

I still think your GOPATH is wrong. First set your GOPATH then use go get to download the code. If you want to use git clone then you need to create the entire path yourself.

mkdir ~/gopath
export GOPATH=~/gopath
go get -u github.com/eBay/fabio # will fetch source, compile it and put binary into $GOPATH/bin

with git clone

mkdir -p ~/gopath/src/github.com/eBay
git clone github.com/eBay/fabio ~/gopath/src/github.com/eBay
export GOPATH=~/gopath
go install github.com/eBay/fabio # will compile binary into $GOPATH/bin

That's why you should use go get unless you know what you're doing.

But the main problem is actually go1.3.3. From https://github.com/eBay/fabio#installation:

To install fabio run (you need Go 1.4 or higher)

atomic.Value was introduced with Go 1.4. https://golang.org/doc/go1.4

[magiconair]

However, use Go 1.5 since it has a more predictable garbage collector. Get the binaries for Linux from here: https://golang.org/dl/

[magiconair]

To complete this:

mkdir ~/gopath
export GOPATH=~/gopath
go get -u github.com/eBay/fabio
cd $GOPATH/src/github.com/eBay/fabio
git checkout v1.0.7
go install # will build v1.0.7 in $GOPATH/bin

I've also started putting pre-compiled binaries in the releases section: https://github.com/eBay/fabio/releases