opts with host= with multiple routes does not work as expected

[discobean]

In Fabio 1.5.3 say I have 2 routes as such:

route add new-location-api location-api.domain.com/ http://localhost:9999 opts "host=new-location-api.domain.com"
route add old-location-api location-api.domain.com/ http://domain-location-api-production-external.dynamic.domain.com

The host=xxxx option appears on both routes. (But notice the second route does not specify a host option)

If you put the second route above the first, then neither route has a host= option.

[magiconair]

Found it. The opts are stored on the target itself but set on the route for all targets.

fabio/route/table.go

Lines 156 to 157 in 4dbab1b

	r := &Route{Host: host, Path: path, Opts: d.Opts}
	r.addTarget(d.Service, targetURL, d.Weight, d.Tags)

fabio/route/table.go

Lines 162 to 163 in 4dbab1b

	r := &Route{Host: host, Path: path, Opts: d.Opts}
	r.addTarget(d.Service, targetURL, d.Weight, d.Tags)

On my way to the airport now. I’ll see what I can do before the flight. Otherwise tomorrow.

[discobean]

All good mate, no need to rush so much :P

[magiconair]

@discobean I want to write an integration test for the host option but if you want then you can test the patch in #388 in the meantime.