Building master fails

[phedoreanu]

Building master fails with:

$ fabio(master) » make                                                                                                                          
[ -x "/Users/test/gocode/bin/govendor" ] || go get -u github.com/kardianos/govendor
govendor list +e | grep '^ e ' && { echo "Found missing packages. Please run 'govendor add +e'"; exit 1; } || : echo
 e  golang.org/x/text/internal/colltab
 e  golang.org/x/text/internal/language
 e  golang.org/x/text/internal/tag
 e  golang.org/x/text/language
 e  golang.org/x/text/transform
 e  golang.org/x/text/unicode/norm
Found missing packages. Please run 'govendor add +e'
make: *** [checkdeps] Error 1

Why aren't they checked into vendor/?

Have you thought switching from govendor to the official dep?

Please also read PackageManagementTools.

To see popularity of these tools, click here.

[phedoreanu]

After adding the missing dependencies, now I get:

 github.com/test/fabio/vendor/github.com/circonus-labs/circonus-gometrics/api
vendor/github.com/circonus-labs/circonus-gometrics/api/account.go:150:46: undefined: SearchFilterType
vendor/github.com/circonus-labs/circonus-gometrics/api/acknowledgement.go:155:87: undefined: SearchFilterType
vendor/github.com/circonus-labs/circonus-gometrics/api/alert.go:96:77: undefined: SearchFilterType
vendor/github.com/circonus-labs/circonus-gometrics/api/annotation.go:188:82: undefined: SearchFilterType
vendor/github.com/circonus-labs/circonus-gometrics/api/checkbundle.go:13:6: CheckBundleConfig redeclared in this block
	previous declaration at vendor/github.com/circonus-labs/circonus-gometrics/api/check_bundle.go:33:6
vendor/github.com/circonus-labs/circonus-gometrics/api/checkbundle.go:20:6: CheckBundleMetric redeclared in this block
	previous declaration at vendor/github.com/circonus-labs/circonus-gometrics/api/check_bundle.go:20:6
vendor/github.com/circonus-labs/circonus-gometrics/api/checkbundle.go:28:6: CheckBundle redeclared in this block
	previous declaration at vendor/github.com/circonus-labs/circonus-gometrics/api/check_bundle.go:36:6
vendor/github.com/circonus-labs/circonus-gometrics/api/checkbundle.go:89:6: (*API).CreateCheckBundle redeclared in this block
	previous declaration at vendor/github.com/circonus-labs/circonus-gometrics/api/check_bundle.go:156:6
vendor/github.com/circonus-labs/circonus-gometrics/api/checkbundle.go:89:6: method redeclared: API.CreateCheckBundle
	method(*API) func(*CheckBundle) (*CheckBundle, error)
	method(*API) func(CheckBundle) (*CheckBundle, error)
vendor/github.com/circonus-labs/circonus-gometrics/api/checkbundle.go:110:6: (*API).UpdateCheckBundle redeclared in this block
	previous declaration at vendor/github.com/circonus-labs/circonus-gometrics/api/check_bundle.go:118:6
vendor/github.com/circonus-labs/circonus-gometrics/api/checkbundle.go:110:6: too many errors
make: *** [build] Error 2

[aaronhurt]

The dep experiment is doomed to fail. It was supposed to be part of the 1.10 official releases but it missed the mark. In my opinion this was largely due to internal fighting and ivory tower perspectives that you can read in the project GitHub issue list. I don't see that project overcoming those issues nor do I ever see it gaining widespread adoption. Case in point there is already another vending tool being pushed vgo that according to the white paper is slated to replace dep that still hasn't been adopted.

[magiconair]

Building master does not fail. Tried this:

make ~/bla
export GOPATH=~/bla
go get github.com/fabiolb/fabio
find -type d ~/bla/src

[magiconair]

See #436 for why fabio won't switch to dep.