strip doesn't work as expected on redirect

[far-blue]

I'm trying to use strip and redirect together and I'm not getting the behaviour I'd expect.

What I'm trying to do is:

urlprefix-<host>/news strip=/news redirect=301,https://<host>/bulletin/$path

However, the strip isn't working.

Looking at the code here:

fabio/route/target.go

Line 99 in 231e7f2

if t.StripPath != "" && strings.HasPrefix(t.RedirectURL.Path, t.StripPath) {

It looks like the redirect destination is assembled first, and then the strip prefix is checked. In my case this would first convert /new/foo into /bulletin/news/foo, then attempt to apply the strip - which will fail.

I suspect the code should actually be applying the prefix check and strip to the replaceRawPath var rather than the t.RedirectURL.Path var.

[aaronhurt]

@far-blue You are correct. The path stripping is currently done AFTER the replacement of the $path pseudo variable in the code. I added a new test case and have a patch I'll push shortly.

[aaronhurt]

I also added a new test case for this issue. The fix passes the new test and all existing tests.

fabio/route/target_test.go

Lines 146 to 155 in d8c81f8

	{ // strip prefix and redirect #824
	route: "route add svc *:80/stripme https://bar.com/bbb$path opts \"strip=/stripme\"",
	tests: []routeTest{
	{req: "/stripme", want: "https://bar.com/bbb"},
	{req: "/stripme/abc", want: "https://bar.com/bbb/abc"},
	{req: "/stripme/a/b/c", want: "https://bar.com/bbb/a/b/c"},
	{req: "/stripme/?aaa=1", want: "https://bar.com/bbb/?aaa=1"},
	{req: "/stripme/abc/?aaa=1", want: "https://bar.com/bbb/abc/?aaa=1"},
	},
	},

Let me know if this resolves your issue.

[far-blue]

Great, thanks for this. I don't have experience with building go apps but your unit tests capture the behaviour as I'd expect so if they are passing I'm confident the issue will be fixed :)