Drop default port from request

[mazhack]

2016/04/26 15:30:40 [INFO] consul: Using tag prefix "fabio_prod-"
2016/04/26 15:30:40 [INFO] consul: Watching KV path "/fabio_prod/config"
2016/04/26 15:30:40 [INFO] consul: Manual config changed to #1
2016/04/26 15:30:40 [INFO] HTTPS proxy listening on :443 with certificate /etc/fabio/ssl/wildcard_lostaxis_com.ca-bundle
2016/04/26 15:30:40 [INFO] Updated config to
2016/04/26 15:30:40 [INFO] consul: Health changed to #2181
2016/04/26 15:30:40 [INFO] Updated config to
route add losmovilesapi_lostaxis losmovilesapi.lostaxis.com/ http://192.168.100.123:32774/ tags "losmovilesapi.lostaxis.com,fabio_prod-losmovilesapi.lostaxis.com/"
2016/04/26 15:30:41 [WARN] No route for losmovilesapi.lostaxis.com:443/v1/driver/13543547/835
2016/04/26 15:30:41 [WARN] No route for losmovilesapi.lostaxis.com:443/v1/driver/13543547/835
2016/04/26 15:30:41 [WARN] No route for losmovilesapi.lostaxis.com:443/v1/driver/13543547/835
2016/04/26 15:30:41 [WARN] No route for losmovilesapi.lostaxis.com:443/v1/driver/13543547/835
2016/04/26 15:30:41 [WARN] No route for losmovilesapi.lostaxis.com:443/v1/driver/13543547/835
2016/04/26 15:30:41 [WARN] No route for losmovilesapi.lostaxis.com:443/v1/driver/13543547/835
2016/04/26 15:30:41 [WARN] No route for losmovilesapi.lostaxis.com:443/v1/driver/13543547/835
2016/04/26 15:30:41 [WARN] No route for losmovilesapi.lostaxis.com:443/v1/driver/13543547/835
2016/04/26 15:30:41 [WARN] No route for losmovilesapi.lostaxis.com:443/v1/driver/13543547/835
2016/04/26 15:30:42 [WARN] No route for losmovilesapi.lostaxis.com:443/v1/driver/13543547/835
2016/04/26 15:30:42 [WARN] No route for losmovilesapi.lostaxis.com:443/v1/driver/13543547/835

¿the port 443 is not removed from route?

losmovilesapi.lostaxis.com:443/ != losmovilesapi.lostaxis.com/

[mazhack]

i change the tag, and now do not work without 443

2016/04/26 15:43:45 [INFO] consul: Health changed to #2208
2016/04/26 15:43:45 [INFO] Updated config to
route add losmovilesapi_lostaxis losmovilesapi.lostaxis.com:443/ http://192.168.100.123:32775/ tags "losmovilesapi.lostaxis.com,fabio_prod-losmovilesapi.lostaxis.com:443/"
2016/04/26 15:43:52 [WARN] No route for losmovilesapi.lostaxis.com/losmoviles/api/driver/1095923341/993
2016/04/26 15:43:52 [WARN] No route for losmovilesapi.lostaxis.com/losmoviles/api/driverphoto/1095923341
2016/04/26 15:43:52 [WARN] No route for losmovilesapi.lostaxis.com/losmoviles/api/driver/1095923341/993
2016/04/26 15:43:52 [WARN] No route for losmovilesapi.lostaxis.com/losmoviles/api/driver/1095923341/993

[mazhack]

finally it works but i need define 2 routes

2016/04/26 15:46:29 [INFO] Updated config to
route add losmovilesapi_lostaxis losmovilesapi.lostaxis.com/ http://192.168.100.123:32776/ tags "losmovilesapi.lostaxis.com,fabio_prod-losmovilesapi.lostaxis.com:443/,fabio_prod-losmovilesapi.lostaxis.com/"
route add losmovilesapi_lostaxis losmovilesapi.lostaxis.com:443/ http://192.168.100.123:32776/ tags "losmovilesapi.lostaxis.com,fabio_prod-losmovilesapi.lostaxis.com:443/,fabio_prod-losmovilesapi.lostaxis.com/"

all traffic is https, only 443 port is open, see the first comment. it is a bug or a feature?

[magiconair]

Hmm, that looks like a bug. I'll have a look.

[magiconair]

My guess is the same thing happens when you add a route for urlprefix-foo.com/ and call fabio with http://foo.com:80/. When I look at the table below then the fix would be to drop the default port from the incoming request. That means http://foo.com:80/ would be translated to http://foo.com/ and https://foo.com:443/ to https://foo.com/ before lookup.

In both cases the urlprefix-foo.com/ route would match but neither urlprefix-foo.com:80/ nor urlprefix-foo.com:443/ would although they would be an exact match with the incoming request. They would only match if :80 (or :443) is not the default port, .e.g http://foo.com:443/ or https://foo.com:80/.

This would only become a problem if you want to match on certain protocols I guess which I'm going to address when introducing the new prefix syntax as described in #42.

I guess dropping the default port from the incoming request is what you would expect to happen. But there is a small chance that this will break someones setup if they have a prefix urlprefix-foo.com:80/ with requests for http://foo.com:80/ which will then no longer match. I'll probably have to hide this behind a switch so that you can revert to the old behavior.

url                     urlprefix       match
http://foo.com/         foo.com/        yes
http://foo.com:80/      foo.com/        yes
http://foo.com:443/     foo.com/        no

http://foo.com/         foo.com:80/     yes
http://foo.com:80/      foo.com:80/     yes
http://foo.com:443/     foo.com:80/     no
http://foo.com:443/     foo.com:443/    no

https://foo.com/        foo.com/        yes
https://foo.com:443/    foo.com/        yes
https://foo.com:80/     foo.com/        no

https://foo.com/        foo.com:443/    yes
https://foo.com:443/    foo.com:443/    yes
https://foo.com:80/     foo.com:443/    no
https://foo.com:80/     foo.com:80/     yes

[magiconair]

@mazhack I've pushed a fix for this into a branch. I still need to add a switch to the configuration but could you check whether that works for you?

[mazhack]

Perfect, this fix my problems in ticket #87 too. Now i can redirect traffic using the protocol default port. Thank you. I am using fabio in production and is amazing!!!