Skip to content

added support for profile/tracing#624

Merged
pschultz merged 2 commits into
masterfrom
issue-623-add-tracing
Jun 3, 2019
Merged

added support for profile/tracing#624
pschultz merged 2 commits into
masterfrom
issue-623-add-tracing

Conversation

@galen0624

Copy link
Copy Markdown
Collaborator

@galen0624

Copy link
Copy Markdown
Collaborator Author

@magiconair @leprechau any chance I could be added to the codeship site to debug the build issues? I assume it's related to the go mod/sum. Below is a make test output that shows it working.
issue-623-make-test.txt

@mfuterko

Copy link
Copy Markdown
Contributor

Hi, @galen0624 can't this be a problem?

--- FAIL: TestLoadAuthSchemes (0.00s) --- FAIL: TestLoadAuthSchemes/should_fail_when_auth_scheme_fails_to_load (0.00s) auth_test.go:25: got stat /some/non/existent/file: no such file or directory, want open /some/non/existent/file: no such file or directory

If so please try merging my pull request (#617) into your branch to fix it.

@galen0624

Copy link
Copy Markdown
Collaborator Author

@mfuterko Thank you for the help!

@pires pires left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't this merged?

@pschultz pschultz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too.

@pschultz pschultz merged commit 22fa963 into master Jun 3, 2019
@magiconair magiconair added this to the 1.5.12 milestone Oct 11, 2019
@aaronhurt aaronhurt deleted the issue-623-add-tracing branch January 23, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants