use vendor directory when building - fixes #638#639
Merged
Conversation
Member
Author
|
Anyone see any problems with this? It does force using golang 1.11+ to build but I think we're already there. |
Member
|
Go 1.10 and earlier are not supported by the maintainers since 1.12 has been released, so dropping support here is totally fine, I think. Since Go <= 1.8 won't work anymore, you can change the |
pschultz
reviewed
Apr 15, 2019
pschultz
left a comment
pschultz
left a comment
Member
There was a problem hiding this comment.
The go list is superfluous too.
Member
Author
|
Yeah I caught that ... just didn't get it in that last commit |
aaronhurt
force-pushed
the
issue-638-mod-use-vendor
branch
from
04f31dc to
c1b51c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.