https+tcp+sni listener support#784
Merged
Merged
Conversation
nathanejohnson
force-pushed
the
feature/httpstcpsni
branch
2 times, most recently
from
259b023 to
9f92192
Compare
nathanejohnson
force-pushed
the
feature/httpstcpsni
branch
6 times, most recently
from
7f1f8f2 to
0cbf12c
Compare
Member
Author
|
I'll give this a few days, failing any negative reviews I'm merging this. So deadline is September 2 to voice concerns |
dcarbone
requested changes
Aug 31, 2020
dcarbone
left a comment
dcarbone
left a comment
Contributor
There was a problem hiding this comment.
lgtm, only actual problem i see is unbuffered errChan in .Close(), unless there is a reason for it to be unbuffered that i'm unaware of.
dcarbone
requested changes
Aug 31, 2020
Adds support for the https+tcp+sni listener. Any routes that are marked with proto=tcp or have a scheme tcp:// will be matched for TCP steering. Failing any matches there, fallthrough will be to https matching. This resolves: fabiolb#783. clean up error handling on 'use of closed network connection' case fix makefile tag finding stuff fix logic for https+tcp+sni matching so that only explicit proto=tcp matches Adding an integration test make sure proxy is listening before starting test add buffered err chan to Close() per dcarbone add 1.14 and 1.15 to travis tests
nathanejohnson
force-pushed
the
feature/httpstcpsni
branch
from
af3823d to
ffec71e
Compare
This was referenced Dec 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the https+tcp+sni listener. Any host routes that are marked with
proto=tcp or have a scheme tcp:// will be matched for TCP SNI steering. Failing
any matches there, fallthrough will be to https matching. This resolves: #783.
clean up error handling on 'use of closed network connection' case
fix makefile tag finding stuff
fix logic for https+tcp+sni matching so that only explicit proto=tcp matches