Update and try fix GH Pages publish action.#953
Merged
Conversation
Member
Author
|
@aaronhurt tested on my fork see |
dcarbone
requested changes
Sep 9, 2024
dcarbone
left a comment
dcarbone
left a comment
Contributor
There was a problem hiding this comment.
One small change, otherwise lgtm
Contributor
There was a problem hiding this comment.
Change this to @v4, please
nathanejohnson
requested changes
Sep 9, 2024
nathanejohnson
left a comment
nathanejohnson
left a comment
Member
There was a problem hiding this comment.
it looks like there are whitespace issues with this commit as well, the file uses spaces for indent
tristanmorgan
force-pushed
the
fix_gh_pages
branch
from
cde52b8 to
2f757f6
Compare
Member
Author
|
I pinned the actions/checkout version to v4, and dropped the formatting commit. |
nathanejohnson
approved these changes
Sep 9, 2024
dcarbone
approved these changes
Sep 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from the latest version of the gh-pages docs it should use GITHUB_TOKEN to authenticate...