feat: implement hotkey to cycle through common footway types#1198
Merged
Bonkles merged 2 commits intofacebook:mainfrom Nov 2, 2023
Merged
feat: implement hotkey to cycle through common footway types#1198Bonkles merged 2 commits intofacebook:mainfrom
Bonkles merged 2 commits intofacebook:mainfrom
Conversation
Contributor
|
Hi @RitaDee - your PR template includes the fact that you added tests, but I don't see any new tests checked in to this PR. |
Contributor
Author
Apologies, I have fixed that. |
Contributor
|
No worries! Already the PR template is giving me some good vibes, as it gives me a pretty good instant read on the content that's included. Also, great job on including a video showing the feature working- I would have requested one had no not made one. :) |
Bonkles
approved these changes
Nov 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new feature (a hotkey) that enables users to easily cycle through crosswalk tags within the OSM editing context. The operation supports keyboard shortcuts, provides a tooltip with descriptive information, and includes annotation.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Fixes #1154
Mobile & Desktop Screenshots/Recordings
Before:
Screen.Recording.2023-11-01.at.23.23.57.mov
After:
Screen.Recording.2023-11-01.at.23.02.31.mov
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?