Not compatible with VS Code + ESLint plugin

[kyleect]

Perhaps this is an issue not in the scope of this project but...

Steps

1. $ create-react-app testApp && cd testApp
2. Open project in VS Code with ESLint plugin installed
3. Open any javascript file

Expected

ESLint plugin lints my code and displays errors.

Actual

VS Code display this error: No ESLint configuration found

---

This makes sense because there isn't an eslint config file anywhere. I ran npm run eject and changed config/eslint.js to config/.eslintrc.js to match '**/.eslintr{c.js,c.yaml,c.yml,c,c.json}' per https://github.com/Microsoft/vscode-eslint/blob/master/eslint/extension.ts#L40. This didn't fix the issue. Does anyone have any suggestions?

[lacker]

Is the issue that it doesn't work with VS Code + ESLint out of the box, or that even after ejecting you couldn't get it to work with VS Code + ESLint?

[kyleect]

After ejection. I think its reasonable that it doesn't work out of the box as there is no config file by design.

[mxstbr]

After ejection is definitely a bug, but I wonder if we can somehow fix this before ejection too?

[gaearon]

We should probably put eslint "extends" into package.json (eslint supports that), and point extends to our config.

[vjeux]

cc @jamesgpearce who mentioned this for Nuclide as well

[gaearon]

One constraint I'd like to operate under is we don't create configuration files as part of project init.

It's okay to add a key-value pair to package.json but please let's try to keep this as simple as possible.

[gaearon]

Ideally I'd like different tools to adopt a convention of configuration field in package.json that would specify base directory for all configs. We would just put react-scripts/config there, and Flow and ESLint could autodiscover them there. Tools don't currently support this because zero conf environments are rare in JS.

[kyleect]

A temporary workaround (preventing the error from keep popping up) in VS Code is setting in my workspace settings.

{
  "eslint.enabled": false
}

[kevinastone]

Dumb question, isn't that implied by the absence of an eslint config? Is VSCode being a bit obnoxious here?

[kyleect]

Totally reasonable pre-ejection but post-ejection there is a eslint config file. I'd be fine ejecting to get this to work but what I've tried hasn't fixed the issue.

[keyz]

#149 should fix this.

[kevinastone]

Worth highlighting that #149 requires the IDE to have the same eslint plugins since it's not using the embedded copy of eslint within react-scripts.

(took me a bit to figure out my version of babel-eslint was out of date)