Skip to content

Extend --scripts-version to support more formats #3573

@SaschaDens

Description

@SaschaDens

For a project I want to use a custom react-scripts to provide additional tasks for code compilation.
Here I wanted to make use --scripts-version with a default generated .tar.gz file from GitLab.

But --scripts-version only looks for the .tgz extension and therefor the command fails. I was initially confused by the following line createReactApp.js#L374 but after digging in the code I found that there is only a check done for .tgz.

I can create a PR for this to further extend the checks done at createReactApp.js#L419 to also look for .tar and .tar.gz formats as the package that's used to extract the content also supports these formats (tar-pack), and also extend the documentation and console output as documentation is currently limited for --scripts-version (GIT is apparently also supported).

Would it make sense?

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions