Skip to content

Switch to preset-env #1742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Timer merged 3 commits into from
Mar 7, 2017
+19 −14
Merged

Switch to preset-env #1742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
256d705
Switch to preset-env
Timer Mar 6, 2017
195df07
Bump babel-core to match babel preset versions
Timer Mar 6, 2017
e74b9af
Add uglify to targets
Timer Mar 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions packages/babel-preset-react-app/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,16 @@ if (env === 'test') {
module.exports = {
presets: [
// Latest stable ECMAScript features
[require.resolve('babel-preset-latest'), {
'es2015': {
modules: false
}
[require.resolve('babel-preset-env'), {
targets: {
// React parses on ie 9, so we should too
ie: 9,
// We currently minify with uglify
// Remove after https://github.com/mishoo/UglifyJS2/issues/448
Copy link
Copy Markdown
Contributor

@ForbesLindesay ForbesLindesay Jun 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mishoo/UglifyJS#448 appears to be closed, but this comment is still in the code. Can we remove uglify: true or should the comment be updated?

Copy link
Copy Markdown
Contributor

@gaearon gaearon Jun 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we switch to Uglify 3 then we can probably remove it.

uglify: true
},
// Disable polyfill transforms
useBuiltIns: false
}],
// JSX, Flow
require.resolve('babel-preset-react')
Expand Down
17 changes: 8 additions & 9 deletions packages/babel-preset-react-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,16 @@
"dependencies": {
"babel-plugin-dynamic-import-node": "1.0.0",
"babel-plugin-syntax-dynamic-import": "6.18.0",
"babel-plugin-transform-class-properties": "6.22.0",
"babel-plugin-transform-object-rest-spread": "6.22.0",
"babel-plugin-transform-react-constant-elements": "6.22.0",
"babel-plugin-transform-react-jsx": "6.22.0",
"babel-plugin-transform-class-properties": "6.23.0",
"babel-plugin-transform-object-rest-spread": "6.23.0",
"babel-plugin-transform-react-constant-elements": "6.23.0",
"babel-plugin-transform-react-jsx": "6.23.0",
"babel-plugin-transform-react-jsx-self": "6.22.0",
"babel-plugin-transform-react-jsx-source": "6.22.0",
"babel-plugin-transform-regenerator": "6.22.0",
"babel-plugin-transform-runtime": "6.22.0",
"babel-preset-env": "1.1.8",
"babel-preset-latest": "6.22.0",
"babel-preset-react": "6.22.0",
"babel-runtime": "6.22.0"
"babel-plugin-transform-runtime": "6.23.0",
"babel-preset-env": "1.2.1",
"babel-preset-react": "6.23.0",
"babel-runtime": "6.23.0"
}
}
2 changes: 1 addition & 1 deletion packages/react-scripts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
},
"dependencies": {
"autoprefixer": "6.7.5",
"babel-core": "6.22.1",
"babel-core": "6.23.1",
"babel-eslint": "7.1.1",
"babel-jest": "18.0.0",
"babel-loader": "6.3.2",
Expand Down
⚡