docs: added REACT_EDITOR to Advanced Configuration section#2445
Merged
gaearon merged 3 commits intofacebook:masterfrom Jun 27, 2017
Merged
docs: added REACT_EDITOR to Advanced Configuration section#2445gaearon merged 3 commits intofacebook:masterfrom
Advanced Configuration section#2445gaearon merged 3 commits intofacebook:masterfrom
Conversation
Contributor
|
Hi! I'm going to hold off on merging this temporarily as we're probably going to land #2552 soon. |
Contributor
Contributor
|
Thanks! I tweaked the wording a little bit. |
This was referenced Jun 27, 2017
Merged
romaindso
pushed a commit
to romaindso/create-react-app
that referenced
this pull request
Jul 10, 2017
…k#2445) * docs: added REACT_EDITOR to `Advanced Configuration` section * Update README.md * Update launchEditor.js
wmonk
referenced
this pull request
in wmonk/create-react-app-typescript
Aug 7, 2017
* docs: added REACT_EDITOR to `Advanced Configuration` section * Update README.md * Update launchEditor.js
morgs32
pushed a commit
to BrickworkSoftware/create-react-app
that referenced
this pull request
Sep 1, 2017
…k#2445) * docs: added REACT_EDITOR to `Advanced Configuration` section * Update README.md * Update launchEditor.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2406
Should I also add a new section to the User Guide?