Show warning when trying to run on port below 1024 without admin permissions under Linux/macOS#2518
Conversation
…issions under Linux
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
levrik
changed the title
|
Warning shows up in a Mac (OS X 10.11 with ohmyzsh).
|
|
@afontcu Thank you for testing. PR is ready now. |
trueadm
left a comment
trueadm
left a comment
There was a problem hiding this comment.
Looks great to me. Thank you for this!
|
Fixed in 1.0.8. Please verify. |
…issions under Linux (facebook#2518)
…issions under Linux (#2518)
5 participants
On Linux/macOS (and WSL too) it requires admin permissions to run a server on a port below 1024.
I'm shifting my development stuff to WSL on Windows at the moment and didn't know that so it would be nice to show another message in this case.
ref #2512