Skip to content

Add json and css to lint-staged in template README #2671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaearon merged 3 commits into from
Jun 28, 2017
Merged

Add json and css to lint-staged in template README #2671

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a4dd4f
Add json and css to lint-staged in template README
jbovenschen Jun 28, 2017
6ed782a
Use capitalization for Javascript, CSS and JSON
Jun 28, 2017
0445c4b
Change 'Javascript to JavaScript'
Jun 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/react-scripts/template/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ Start your app by running `npm start`, and start debugging in VS Code by pressin

## Formatting Code Automatically

Prettier is an opinionated JavaScript formatter. With Prettier you can format the code you write automatically to ensure a code style within your project. See the [Prettier's GitHub page](https://github.com/prettier/prettier) for more information, and look at this [page to see it in action](https://prettier.github.io/prettier/).
Prettier is an opinionated code formatter with support for javascript, css and json. With Prettier you can format the code you write automatically to ensure a code style within your project. See the [Prettier's GitHub page](https://github.com/prettier/prettier) for more information, and look at this [page to see it in action](https://prettier.github.io/prettier/).
Copy link
Copy Markdown
Contributor

@gaearon gaearon Jun 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use capitalization for JavaScript, CSS, JSON


To format our code whenever we make a commit in git, we need to install the following dependencies:

Expand Down Expand Up @@ -307,7 +307,7 @@ Next we add a 'lint-staged' field to the `package.json`, for example:
// ...
},
+ "lint-staged": {
+ "src/**/*.{js,jsx}": [
+ "src/**/*.{js,jsx,json,css}": [
+ "prettier --single-quote --write",
+ "git add"
+ ]
Expand Down
⚡