Don't prompt to install serve if already installed#2761
Don't prompt to install serve if already installed#2761gaearon merged 3 commits intofacebook:masterfrom OwenFlood:master
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Looks fine to me! Let's wait for CI to pass. |
|
Wow, sick PR Owen. Would push the 'owen-dank1' button if I could. |
|
Hi there! This change is out in |
* dont prompt if serve is already installed * change name for readability * Pin the version
* dont prompt if serve is already installed * change name for readability * Pin the version
* dont prompt if serve is already installed * change name for readability * Pin the version
* dont prompt if serve is already installed * change name for readability * Pin the version
* dont prompt if serve is already installed * change name for readability * Pin the version
5 participants
This PR (#2750) removes the line prompting to install
serveif the user already has it installed globally. Tested on Mac OS with and without serve installed.