Add warning when HOST environment variable is set (#3719)#3730
Merged
Timer merged 3 commits intofacebook:masterfrom Jan 14, 2018
Merged
Add warning when HOST environment variable is set (#3719)#3730Timer merged 3 commits intofacebook:masterfrom
Timer merged 3 commits intofacebook:masterfrom
Conversation
Contributor
|
Can you please shorten the link? Let's make the second log more along these lines: `Learn more here: ${chalk.yellow('http://bit.ly/2mwWSwH')}` |
gaearon
reviewed
Jan 14, 2018
| if (process.env.HOST) { | ||
| console.log( | ||
| chalk.yellow( | ||
| "Attempting to bind to $HOST because it was specified. If this was unintentional, check that you haven't mistakenly set it in your shell." |
Contributor
There was a problem hiding this comment.
Shouldn't we inline the HOST value in the message?
Also it's not 100% clear what "$HOST" is. (For example windows uses a different syntax for environment variables.) It is better to explicitly say "environment variable".
Contributor
Author
There was a problem hiding this comment.
What if it was something more like "Attempting to bind to HOST environment variable somehostname.example.com. If this was..."
gaearon
approved these changes
Jan 14, 2018
Contributor
gaearon
left a comment
gaearon
left a comment
There was a problem hiding this comment.
LGTM (haven't run it though)
Contributor
|
Thanks! |
Contributor
|
Adjusted the colors a bit: |
Contributor
Author
|
Looks good! 👍 |
ghost
mentioned this pull request
This was referenced Feb 2, 2018
Pavek
pushed a commit
to Pavek/create-react-app
that referenced
this pull request
Jul 10, 2018
* Add warning when HOST environment variable is set (facebook#3719) * Improve HOST environment variable warning message * Adjust text and message Closes facebook#3719
zmitry
pushed a commit
to zmitry/create-react-app
that referenced
this pull request
Aug 14, 2018
* Add warning when HOST environment variable is set (facebook#3719) * Improve HOST environment variable warning message * Adjust text and message Closes facebook#3719
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To see the new warning message run
HOST=8.8.8.8 npm run start.Closes #3719