Use private registry#3744
Merged
Timer merged 3 commits intofacebook:masterfrom Jan 11, 2018
Merged
Conversation
ghost
mentioned this pull request
|
include a link to verdaccio? google is broken for me right now |
Pavek
pushed a commit
to Pavek/create-react-app
that referenced
this pull request
Jul 10, 2018
* Run e2e-simple in a realistic scenario * Use npx for everything * oops
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes a lot of the painful trickery we do via setting up a local registry and actually publishes the modules.
We can now test as if we're an end-user. This means our tests actually mean something now. 😄
verdacciois used to spin up a lightweight local registry. It allows you to publish packages and uses npm as its fallback.verdacciosupports an anonymous publishing mode, but I'd rather not ship a config file with this.Since we use
verdaccio's defaults, you must login to publish a package.Due to long standing npm issue, we have to use
npm-cli-loginto login (over standardnpm adduser).Packages are released using our
release.shscript.The
create_react_appfunction, ourinstall_packagenpm link workaround, andnpm packofreact-scriptsare all gone 🎉.In hindsight, I can't believe we ever did it different than this. Seriously.