Remove PropTypes from production build (#209)

[iansu]

Apply babel-plugin-transform-react-remove-prop-types when building for production.

Closes #209

[gaearon]

Can/should we also add https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/forbid-foreign-prop-types.md?

[gaearon]

Hmm. I feel like that ESLint rule is too restrictive.

It should be perfectly okay to use another component's propTypes inside a propTypes definition.

Button.propTypes = {
  ...Touchable.propTypes,
  color: PropTypes.string
}

The message is also not friendly:

Using another component's propTypes is forbidden 

It should say something like

Reading propTypes from the component is not safe because it may be removed in production

Can you follow up with eslint-plugin-react about this and remove the rule in the meantime please?

[csantos1113]

I'm too late on this thread. but what about the scenario that @gaearon mentioned about:

Button.propTypes = {
  ...Touchable.propTypes,
  color: PropTypes.string
}

?

[iansu]

I made a PR to eslint-config-react to allow for that scenario before we enabled this plugin: jsx-eslint/eslint-plugin-react#1655

[csantos1113]

@iansu - thanks for the quick reply. Why about this case:

const space = () => {};
space.propTypes = {
    b: PropTypes.string,
    name: PropTypes.string
};

export default class List extends PureComponent {
  static propTypes = {
    ...space.propTypes, // but I'm getting the warning here!
    message: PropTypes.string,
    b: space.propTypes.b // same here
  }

  render() {
     return <div>{this.props.message}</div>
  }
}

[iansu]

I'm not sure why you'd be getting the warning in that case. This would need to be addressed in eslint-plugin-react so you should file an issue there.