Add svg rendering for error example#3825
Merged
gaearon merged 2 commits intofacebook:nextfrom Jan 17, 2018
Merged
Conversation
Contributor
|
Thanks! How hard would it be to do the test runner with a filtering example? |
Contributor
Author
|
Should be doable, what pattern do you have in mind? |
Contributor
|
Just "app" maybe |
Contributor
Author
Contributor
|
I think it would look more impressive if there were more tests 😄 Can we use some open source project? e.g. Redux examples use CRA scripts. Another minor thing is that Jest removed autocomplete in 22 because of some issues. So let's wait until we release 2.x alpha and then we can record the more recent behavior. |
akstuhl
pushed a commit
to akstuhl/create-react-app
that referenced
this pull request
Mar 15, 2018
* Add svg rendering for error example * Use static svg error example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
screencast:errorrun-script