Skip to content

Move favicon.ico <link> to accommodate Chrome#4891

Merged
Timer merged 1 commit intofacebook:nextfrom
thejohnfreeman:favicon-link
Sep 21, 2018
Merged

Move favicon.ico <link> to accommodate Chrome#4891
Timer merged 1 commit intofacebook:nextfrom
thejohnfreeman:favicon-link

Conversation

@thejohnfreeman
Copy link
Copy Markdown
Contributor

@thejohnfreeman thejohnfreeman commented Aug 14, 2018

Chrome requests favicon.ico on every route change, but stops if the <link> for it occurs early enough in the page. Several other people have been running into this issue since at least February 2016.

@thejohnfreeman
Move favicon.ico <link> to accommodate Chrome
527d73b 
Chrome requests `favicon.ico` on every route change, but stops if the `<link>` for it occurs early enough in the page. [Several](https://stackoverflow.com/questions/35409588/favicon-requested-on-every-route-change) other [people](ctrlplusb/react-universally#145) have been running into this issue since at least February 2016.
@facebook-github-bot
Copy link
Copy Markdown

facebook-github-bot commented Aug 14, 2018

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@thejohnfreeman
Copy link
Copy Markdown
Contributor Author

thejohnfreeman commented Aug 14, 2018

I just signed the CLA. Is it just me, or are the CI failures unrelated to my change?

@facebook-github-bot
Copy link
Copy Markdown

facebook-github-bot commented Aug 14, 2018

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@petetnt
Copy link
Copy Markdown
Contributor

petetnt commented Aug 15, 2018

@thejohnfreeman it's unrelated, #4890 should fix the CI 👍

@Timer
Copy link
Copy Markdown
Contributor

Timer commented Sep 21, 2018

/cc @jeffposnick is this a thing?

@Timer Timer added this to the 2.0.0 milestone Sep 21, 2018
@jeffposnick
Copy link
Copy Markdown
Contributor

jeffposnick commented Sep 21, 2018

It's not something that I've heard folks complain about. I'd recommend folks who can reproduce the behavior and believe it's a bug in Chrome to open an issue at https://crbug.com with details.

That being said, this seems like a harmless change to make in c-r-a in the meantime?

@Timer Timer merged commit b98d5c9 into facebook:next Sep 21, 2018
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Sep 30, 2018
@thejohnfreeman @Timer
Move favicon.ico <link> to accommodate Chrome (facebook#4891)
2a8aef1 
Chrome requests `favicon.ico` on every route change, but stops if the `<link>` for it occurs early enough in the page. [Several](https://stackoverflow.com/questions/35409588/favicon-requested-on-every-route-change) other [people](ctrlplusb/react-universally#145) have been running into this issue since at least February 2016.
@lock lock Bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed tag: internal

Projects

None yet

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

6 participants

@thejohnfreeman @facebook-github-bot @petetnt @Timer @jeffposnick @kovryzhenko
⚡