as per #5104#5105
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Hmm, how about the following:
|
|
@Timer I like this because it covers 3.x and above versions as well 😆 |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@Timer Is there a migration guide somewhere? |
|
No need for one. We explain how to migrate at the top of the README. ... and it doesn't exist yet |
|
So maybe an internal link to top section? ... eg: |
|
This is good enough for now, thanks! |
* changed to Migrate to v2.x * richer explanation * Update README.md
Update npm run build fails to minify section.
as per #5104