PostCSS should run on @import statements.#929
Merged
gaearon merged 1 commit intofacebook:masterfrom Oct 19, 2016
Merged
Conversation
nhunzaker
force-pushed
the
nh-fix-autoprefixer-imports
branch
from
a3035b9 to
0562acc
Compare
Contributor
|
LGTM, thanks! |
arunoda
added a commit
to storybookjs/storybook
that referenced
this pull request
Oct 24, 2016
arunoda
added a commit
to storybookjs/storybook
that referenced
this pull request
Oct 24, 2016
feiqitian
pushed a commit
to feiqitian/create-react-app
that referenced
this pull request
Oct 25, 2016
jarlef
pushed a commit
to jarlef/create-react-app
that referenced
this pull request
Nov 28, 2016
alexdriaguine
pushed a commit
to alexdriaguine/create-react-app
that referenced
this pull request
Jan 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like PostCSS isn't running on stylesheets included via
@importwithin another stylesheet. The postcss-loader docs use?importLoaders=1in there configuration. Adding it fixed the issue.Steps to reproduce:
create-react-appApp.cssfromsrc/index.cssimport './App.css'fromsrc/App.jsThe
-webkit-prefix for theanimationstyle rule is gone! I've pushed up an example here:https://github.com/nhunzaker/no-autoprefixer-issue