Bugfix - Cocoapods with generate_multiple_pod_projects#1709
Closed
joesus wants to merge 1 commit intofacebook:masterfrom
Closed
Bugfix - Cocoapods with generate_multiple_pod_projects#1709joesus wants to merge 1 commit intofacebook:masterfrom
joesus wants to merge 1 commit intofacebook:masterfrom
Conversation
Summary: We moved auth token claims to the public headers of corekit but didn't remove it from the internal umbrella header. We also didn't add it to the public header for BUCK builds. This fixes both of those oversights. There was also a weird import of the CoreKit+Internal header in the CoreKit+Internal header. This made no sense so removing. Differential Revision: D27620983 fbshipit-source-id: 5d97849a4ba0329342ddf2bb5a4c12fb07b5b712
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D27620983 |
Contributor
|
This pull request has been merged in 4511cdc. |
joesus
added a commit
that referenced
this pull request
Apr 8, 2021
Summary: Pull Request resolved: #1709 We moved auth token claims to the public headers of corekit but didn't remove it from the internal umbrella header. We also didn't add it to the public header for BUCK builds. This fixes both of those oversights. There was also a weird import of the CoreKit+Internal header in the CoreKit+Internal header. This made no sense so removing. Reviewed By: jamestouri Differential Revision: D27620983 fbshipit-source-id: 24cc10a5bc53568ce9e5cc273011bf147729c441
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
We moved auth token claims to the public headers of corekit but didn't remove it from the internal umbrella header. We also didn't add it to the public header for BUCK builds. This fixes both of those oversights.
There was also a weird import of the CoreKit+Internal header in the CoreKit+Internal header. This made no sense so removing.
Differential Revision: D27620983