Skip to content

Commit a8098ad

Browse files
Saadnajmiclaude
andcommitted
revert: keep macosx routing through build-mac-framework-rn.sh in CI
Keep backward compatibility by preserving the separate mac framework build script in CI. The macosx support in build-ios-framework-rn.sh is still available for downstream consumers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 76d47c1 commit a8098ad

1 file changed

Lines changed: 11 additions & 2 deletions

File tree

.github/workflows/build-apple-slices-hermes.yml

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,17 @@ jobs:
4545
# HermesC is used to build hermes, so it has to be executable
4646
chmod +x ./build_host_hermesc/bin/hermesc
4747
48-
chmod +x ./utils/build-ios-framework-rn.sh
49-
BUILD_TYPE="${{ matrix.flavor }}" ./utils/build-ios-framework-rn.sh "$SLICE"
48+
if [[ "$SLICE" == "macosx" ]]; then
49+
echo "[HERMES] Building Hermes for MacOS"
50+
51+
chmod +x ./utils/build-mac-framework-rn.sh
52+
BUILD_TYPE="${{ matrix.flavor }}" ./utils/build-mac-framework-rn.sh
53+
else
54+
echo "[HERMES] Building Hermes for iOS: $SLICE"
55+
56+
chmod +x ./utils/build-ios-framework-rn.sh
57+
BUILD_TYPE="${{ matrix.flavor }}" ./utils/build-ios-framework-rn.sh "$SLICE"
58+
fi
5059
5160
echo "Moving from build_$SLICE to $FINAL_PATH"
5261
mv build_"$SLICE" "$FINAL_PATH"

0 commit comments

Comments
 (0)