Skip to content

Commit b6db5d6

Browse files
Saadnajmiclaude
andcommitted
revert: keep macosx routing through build-mac-framework.sh in CI
Keep backward compatibility by preserving the separate mac framework build script in CI. The macosx support in build-ios-framework.sh is still available for downstream consumers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent b0f1c05 commit b6db5d6

1 file changed

Lines changed: 11 additions & 2 deletions

File tree

.github/workflows/build-apple-slices-hermes.yml

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,17 @@ jobs:
5555
# HermesC is used to build hermes, so it has to be executable
5656
chmod +x ./build_host_hermesc/bin/hermesc
5757
58-
chmod +x ./utils/build-ios-framework.sh
59-
BUILD_TYPE="${{ matrix.flavor }}" ./utils/build-ios-framework.sh "$SLICE"
58+
if [[ "$SLICE" == "macosx" ]]; then
59+
echo "[HERMES] Building Hermes for MacOS"
60+
61+
chmod +x ./utils/build-mac-framework.sh
62+
BUILD_TYPE="${{ matrix.flavor }}" ./utils/build-mac-framework.sh
63+
else
64+
echo "[HERMES] Building Hermes for iOS: $SLICE"
65+
66+
chmod +x ./utils/build-ios-framework.sh
67+
BUILD_TYPE="${{ matrix.flavor }}" ./utils/build-ios-framework.sh "$SLICE"
68+
fi
6069
6170
echo "Moving from build_$SLICE to $FINAL_PATH"
6271
mv build_"$SLICE" "$FINAL_PATH"

0 commit comments

Comments
 (0)