Skip to content

fix: include macOS slice in universal Hermes xcframework #1970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Saadnajmi wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: include macOS slice in universal Hermes xcframework #1970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f93e87
fix: add macosx support to build-ios-framework.sh and simplify get_ar…
Saadnajmi Apr 15, 2026
2077556
Don't delete the macosx slices
Saadnajmi Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions utils/build-apple-framework.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,10 +232,12 @@ function create_universal_framework {
# shellcheck disable=SC2086
if xcodebuild -create-xcframework $args -output "universal/hermesvm.xcframework"
then
# # Remove the thin iOS hermesvm.frameworks that are now part of the universal
# XCFramework
# Remove the thin hermesvm.frameworks that are now part of the universal
# XCFramework, but keep macosx since it's expected as a standalone framework.
for platform in "${platforms[@]}"; do
rm -r "$platform"
if [[ "$platform" != "macosx" ]]; then
rm -r "$platform"
fi
done
fi

Expand Down
17 changes: 7 additions & 10 deletions utils/build-ios-framework.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,9 @@ set -e
# Given a specific target, retrieve the right architecture for it
# $1 the target you want to build. Allowed values: iphoneos, iphonesimulator, catalyst, xros, xrsimulator
function get_architecture {
if [[ $1 == "iphoneos" || $1 == "xros" ]]; then
if [[ $1 == "iphoneos" || $1 == "appletvos" || $1 == "xros" ]]; then
echo "arm64"
elif [[ $1 == "iphonesimulator" || $1 == "xrsimulator" ]]; then
echo "x86_64;arm64"
elif [[ $1 == "appletvos" ]]; then
echo "arm64"
elif [[ $1 == "appletvsimulator" ]]; then
echo "x86_64;arm64"
elif [[ $1 == "catalyst" ]]; then
elif [[ $1 == "iphonesimulator" || $1 == "appletvsimulator" || $1 == "catalyst" || $1 == "macosx" || $1 == "xrsimulator" ]]; then
echo "x86_64;arm64"
else
echo "Error: unknown architecture passed $1"
Expand All @@ -29,7 +23,9 @@ function get_architecture {
}

function get_deployment_target {
if [[ $1 == "xros" || $1 == "xrsimulator" ]]; then
if [[ $1 == "macosx" ]]; then
echo "$(get_mac_deployment_target)"
elif [[ $1 == "xros" || $1 == "xrsimulator" ]]; then
echo "$(get_visionos_deployment_target)"
else # tvOS and iOS use the same deployment target
echo "$(get_ios_deployment_target)"
Expand All @@ -51,7 +47,7 @@ function build_framework {
# group the frameworks together to create a universal framework
function build_universal_framework {
if [ ! -d destroot/Library/Frameworks/universal/hermesvm.xcframework ]; then
create_universal_framework "iphoneos" "iphonesimulator" "catalyst" "xros" "xrsimulator" "appletvos" "appletvsimulator"
create_universal_framework "macosx" "iphoneos" "iphonesimulator" "catalyst" "xros" "xrsimulator" "appletvos" "appletvsimulator"
else
echo "Skipping; Clean \"destroot\" to rebuild".
fi
Expand All @@ -61,6 +57,7 @@ function build_universal_framework {
# this is used to preserve backward compatibility
function create_framework {
if [ ! -d destroot/Library/Frameworks/universal/hermesvm.xcframework ]; then
build_framework "macosx"
build_framework "iphoneos"
build_framework "iphonesimulator"
build_framework "appletvos"
Expand Down
Loading
⚡