Redefinition of 'Native....SpecJSI' . Error when building with a custom turbo module

[skinnynpale]

Description

Redefinition of 'Native....SpecJSI' . Error when building with a custom turbo module.
I strictly followed the instructions for create turbo module https://reactnative.dev/docs/the-new-architecture/pillars-turbomodules

Steps to reproduce

--

React Native Version

0.73.2

Affected Platforms

Runtime - iOS

Areas

TurboModule - The New Native Module System

Output of npx react-native info

System:
  OS: macOS 14.2.1
  CPU: (12) arm64 Apple M3 Pro
  Memory: 99.55 MB / 18.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 18.19.0
    path: ~/.nvm/versions/node/v18.19.0/bin/node
  Yarn:
    version: 1.22.21
    path: /opt/homebrew/bin/yarn
  npm:
    version: 10.2.3
    path: ~/.nvm/versions/node/v18.19.0/bin/npm
  Watchman:
    version: 2023.12.04.00
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.14.3
    path: /Users/skinnynpale/.rbenv/shims/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.2
      - iOS 17.2
      - macOS 14.2
      - tvOS 17.2
      - visionOS 1.0
      - watchOS 10.2
  Android SDK: Not Found
IDEs:
  Android Studio: 2023.1 AI-231.9392.1.2311.11076708
  Xcode:
    version: 15.2/15C500b
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.9
    path: /usr/bin/javac
  Ruby:
    version: 3.0.6
    path: /Users/skinnynpale/.rbenv/shims/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.73.2
    wanted: 0.73.2
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: true
iOS:
  hermesEnabled: true
  newArchEnabled: true

Stacktrace or Logs

/Users/skinnynpale/Library/Developer/Xcode/DerivedData/a4ord-cnymkqjxmmqjnmfdnnckwsbdoigs/Build/Products/Debug-iphonesimulator/React-Codegen/React_Codegen.framework/Headers/RTNCustomAppBrowserSpec/RTNCustomAppBrowserSpec.h:34:22 Redefinition of 'NativeCustomAppBrowserSpecJSI'

[cipolleschi]

hi @skinnynpale can you share the repository you are using?

[skinnynpale]

hi @skinnynpale can you share the repository you are using?

sorry, only turbo module https://github.com/skinnynpale/RTNCustomAppBrowser

[cipolleschi]

thanks, I'll have a look at this tomorrow morning!

[skinnynpale]

thanks, I'll have a look at this tomorrow morning!

I tried running this, it worked https://github.com/deepthisareddy19/turbonativemodules
but when I pulled out the turbo module (folder RTNCalculator) and installed it in our application, the error is still the same even with it

[cipolleschi]

Hi @skinnynpale, I tried to repro but I couldn't.

You can find my reproducer here this is public, so you should be able to see it.

I think that the problem is with your specific setup. So, we can investigate it a little:

1. If you click on the Error in Xcode, it should show you where are the redefinitions, pointing to the various files where they are defined. One definition is in RTNCalculatorSpec.h file. We need to understand where is the other.
2. Could it be that your app's package.json (not the Turbomodule's one) define a codegenConfig key as well? If yes, it could be that, when running the codegen, we generate the codegen for the library and then the codegen for the app generate the library once again, and we end up with 2 declaration of the JSI interface.

Let me know what you find!

[skinnynpale]

Hi @skinnynpale, I tried to repro but I couldn't.

You can find my reproducer here this is public, so you should be able to see it.

I think that the problem is with your specific setup. So, we can investigate it a little:

1. If you click on the Error in Xcode, it should show you where are the redefinitions, pointing to the various files where they are defined. One definition is in RTNCalculatorSpec.h file. We need to understand where is the other.
2. Could it be that your app's package.json (not the Turbomodule's one) define a codegenConfig key as well? If yes, it could be that, when running the codegen, we generate the codegen for the library and then the codegen for the app generate the library once again, and we end up with 2 declaration of the JSI interface.

Let me know what you find!

Thank you for your reply!

1. any ideas?

[skinnynpale]

Even deleting the "generated" folder from the rtn-calculator itself, where there was another instance creation, did not help