export Props types for end users#22372
Closed
chuckhacker wants to merge 1 commit intofacebook:masterfrom
Closed
Conversation
Generated by 🚫 dangerJS |
Resolved |
Member
|
Thanks for the PR! There is actually an easier way to do this that doesn't require changes to core. You can use Flow's React.ElementProps utility type: Since |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #22100
When using Flow, it is handy to be able to inherit from
Propstype for components in user code because the typing can be stricter.For example:
Test Plan:
Release Notes:
[GENERAL] [ENHANCEMENT] [Components/Touchable/TouchableBounce.js] - export Props Flow types
[GENERAL] [ENHANCEMENT] [Components/Touchable/TouchableHighlight.js] - export Props Flow types
[GENERAL] [ENHANCEMENT] [Components/Touchable/TouchableOpacity.js] - export Props Flow types