Remove RFC-0759 ram-bundle command from cli#43292
Closed
blakef wants to merge 2 commits intofacebook:mainfrom
blakef:export-D54430289
Closed
Remove RFC-0759 ram-bundle command from cli#43292blakef wants to merge 2 commits intofacebook:mainfrom blakef:export-D54430289
blakef wants to merge 2 commits intofacebook:mainfrom
blakef:export-D54430289
Conversation
Summary: Implements the RFC which progressively provides warnings to users of the `npx react-native init` command as we gradually deprecate. Changelog: [General][Deprecated] - init cli deprecation logging Differential Revision: D54423109
Summary: The ram-bundle command isn't necessary now that Hermes is our default VM. The RFC specifically calls for the CLI command to be removed [1]. Changelog: [General][Removed] RFC-0759 remove ram-bundle command. [1] https://github.com/react-native-community/discussions-and-proposals/blob/main/proposals/0759-react-native-frameworks.md#commands-to-be-removed Differential Revision: D54430289
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54430289 |
Contributor
|
This pull request has been merged in 58b45e8. |
DrRefactor
added a commit
to DrRefactor/cli
that referenced
this pull request
Jun 15, 2024
Ram bundle was removed in facebook/react-native#43292 Readme points to non existing command since.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The ram-bundle command isn't necessary now that Hermes is our default VM. The RFC specifically calls for the CLI command to be removed [1].
Changelog:
[General][Removed] RFC-0759 remove ram-bundle command.
[1] https://github.com/react-native-community/discussions-and-proposals/blob/main/proposals/0759-react-native-frameworks.md#commands-to-be-removed
Differential Revision: D54430289