Scope LongLivedObjectCollection per runtime [2/n]#43409
Closed
fabriziocucci wants to merge 1 commit intofacebook:mainfrom
Closed
Scope LongLivedObjectCollection per runtime [2/n]#43409fabriziocucci wants to merge 1 commit intofacebook:mainfrom
fabriziocucci wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Changelog: [General] [Breaking] - Make `LongLivedObject` constructor accept a `Runtime` reference. # Context Approach 1 as described in [RFC post](https://fb.workplace.com/groups/615693552291894/permalink/1693347124526526/). # This diff * Embed `Runtime` reference in `LongLivedObject` to keep supporting `allowRelease` method (and update extending classes accordingly) * Update Microsoft fork accordingly Reviewed By: RSNara Differential Revision: D54638813
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54638813 |
fabriziocucci
added a commit
to fabriziocucci/react-native
that referenced
this pull request
Mar 11, 2024
Summary: Changelog: [General] [Breaking] - Make `LongLivedObject` constructor accept a `Runtime` reference. # Context Approach 1 as described in [RFC post](https://fb.workplace.com/groups/615693552291894/permalink/1693347124526526/). # This diff * Embed `Runtime` reference in `LongLivedObject` to keep supporting `allowRelease` method (and update extending classes accordingly) * Update MSFT fork accordingly Reviewed By: RSNara Differential Revision: D54638813
Base commit: 1ea269f |
Contributor
|
This pull request has been merged in 3706bf0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[General] [Breaking] - Make
LongLivedObjectconstructor accept aRuntimereference.Context
Approach 1 as described in RFC post.
This diff
Runtimereference inLongLivedObjectto keep supportingallowReleasemethod (and update extending classes accordingly)Reviewed By: RSNara
Differential Revision: D54638813