Fix stack overflow in createRootView#43420
Closed
javache wants to merge 1 commit intofacebook:mainfrom
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54772205 |
Summary: Calling `mReactDelegate.createRootView` just ends up calling the overridden method in the anonymous inner class. Instead have the base implementation return null, and call super. Changelog: [Internal] Differential Revision: D54772205
javache
force-pushed
the
export-D54772205
branch
from
79284bb to
21b89d8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54772205 |
Contributor
|
This pull request has been merged in da21799. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Calling
mReactDelegate.createRootViewjust ends up calling the overridden method in the anonymous inner class. Instead have the base implementation return null, and call super.Changelog: [Internal]
Differential Revision: D54772205