Skip to content

[Animated API Example] : - added combining animted values example to the animated api example list#43435

Closed
Biki-das wants to merge 8 commits intofacebook:mainfrom
Biki-das:animated-example
Closed

[Animated API Example] : - added combining animted values example to the animated api example list#43435
Biki-das wants to merge 8 commits intofacebook:mainfrom
Biki-das:animated-example

Conversation

@Biki-das
Copy link
Copy Markdown
Contributor

@Biki-das Biki-das commented Mar 12, 2024

Summary:

Added an example to add combining values with the animated API

Changelog:

[General] [Added] - Add examples for Combining Animated Values with the Animated API

Test Plan:

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-03-12.at.19.46.28.mp4
Screen.Recording.2024-03-12.at.7.25.16.PM.mov

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Mar 12, 2024
@Biki-das
Copy link
Copy Markdown
Contributor Author

Biki-das commented Apr 5, 2024

@hoxyq can we get this merged?

Copy link
Copy Markdown
Contributor

@hoxyq hoxyq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Biki-das, thanks for this contribution!

I think it would be nice also to add 2 inputs for these animated values a, b.
Also cc @cortinico @cipolleschi on L&A aspect of this.

@Biki-das
Copy link
Copy Markdown
Contributor Author

Biki-das commented Apr 8, 2024

Hey @Biki-das, thanks for this contribution!

I think it would be nice also to add 2 inputs for these animated values a, b. Also cc @cortinico @cipolleschi on L&A aspect of this.

@hoxyq could you clarify a bit on this more, seems unclear what you mean by adding two inputs!
do you want me to put two inputs which take the value for a and b, as required and then does the respective
animation api method calculation!

@hoxyq
Copy link
Copy Markdown
Contributor

hoxyq commented Apr 8, 2024

Hey @Biki-das, thanks for this contribution!
I think it would be nice also to add 2 inputs for these animated values a, b. Also cc @cortinico @cipolleschi on L&A aspect of this.

@hoxyq could you clarify a bit on this more, seems unclear what you mean by adding two inputs! do you want me to put two inputs which take the value for a and b, as required and then does the respective animation api method calculation!

Instead of pre-defined values of a and b:

const a = new Animated.Value(0.4);
const b = new Animated.Value(0.5);

Can user actually use inputs on the screen to set them? And then use operators.

@Biki-das
Copy link
Copy Markdown
Contributor Author

Biki-das commented Apr 8, 2024

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-04-08.at.18.43.44.mp4

@hoxyq let me know if this looks fine to you, now it renders two input boxes for the animted values to be experimented with

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@hoxyq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@Biki-das
Copy link
Copy Markdown
Contributor Author

hm... fb internal build and linter is failing, this isn't due to my changes as this has not touched any thing other then the examples!

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Apr 10, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@hoxyq merged this pull request in f7eaf63.

@github-actions
Copy link
Copy Markdown

This pull request was successfully merged by @Biki-das in f7eaf63.

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants