Make ReactContext and ReactApplicationContext classes abstract#43625
Closed
RSNara wants to merge 4 commits intofacebook:mainfrom
Closed
Make ReactContext and ReactApplicationContext classes abstract#43625RSNara wants to merge 4 commits intofacebook:mainfrom
RSNara wants to merge 4 commits intofacebook:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55218590 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55218590 |
RSNara
force-pushed
the
export-D55218590
branch
from
f8f27a0 to
8e46e4f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55218590 |
RSNara
force-pushed
the
export-D55218590
branch
from
8e46e4f to
870095b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55218590 |
RSNara
force-pushed
the
export-D55218590
branch
from
870095b to
e92ea68
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55218590 |
RSNara
force-pushed
the
export-D55218590
branch
from
e92ea68 to
3fcef35
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55218590 |
RSNara
force-pushed
the
export-D55218590
branch
from
3fcef35 to
acb94c6
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55218590 |
RSNara
force-pushed
the
export-D55218590
branch
from
acb94c6 to
fdc8a40
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55218590 |
RSNara
force-pushed
the
export-D55218590
branch
from
fdc8a40 to
f06f0d5
Compare
Summary: Eventually, we will move all bridge methods to BridgeReactContext. Long-term, ReactApplicationContext and ReactContext will become abstract. And these two contexts will only contain methods common to both modes. Changelog: [Android][Added] Introduce BridgeReactContext Differential Revision: https://internalfb.com/D55218592
Summary: Eventaully, ReactApplicationContext.initailizeWithInstance() will be moved to BridgeReactContext. Doing the migration up-front to remove noise from the eventual diff. Changelog: [Internal] Differential Revision: https://internalfb.com/D55218593
Summary: The things that create ReactApplicationContext should instead create BridgeReactContext. Long-term, ReactApplicationContext will be abstract. This diff pulls noise out from that eventual diff. Changelog: [Internal] Differential Revision: https://internalfb.com/D55218591
…ook#43625) Summary: Pull Request resolved: facebook#43625 Changelog: [Android][Breaking] Make ReactApplicationContext and ReactContext abstract. Please instantiate BridgeReactContext instead (bridge mode). Or BridgelessReactContext instead (bridgeless mode). Reviewed By: arushikesarwani94 Differential Revision: D55218590
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55218590 |
RSNara
force-pushed
the
export-D55218590
branch
from
f06f0d5 to
d6adf2a
Compare
Contributor
|
This pull request has been merged in e69f675. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Changelog: [Android][Breaking] Make ReactApplicationContext and ReactContext abstract. Please instantiate BridgeReactContext instead (bridge mode). Or BridgelessReactContext instead (bridgeless mode).
Reviewed By: arushikesarwani94
Differential Revision: D55218590