Scripted: Codemod ReactApplicationContext creators to BridgeReactContext#43626
Closed
RSNara wants to merge 3 commits intofacebook:mainfrom
Closed
Scripted: Codemod ReactApplicationContext creators to BridgeReactContext#43626RSNara wants to merge 3 commits intofacebook:mainfrom
RSNara wants to merge 3 commits intofacebook:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55218591 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55218591 |
RSNara
force-pushed
the
export-D55218591
branch
from
fc384a5 to
6f3bd36
Compare
RSNara
force-pushed
the
export-D55218591
branch
from
6f3bd36 to
eb5f14c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55218591 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55218591 |
RSNara
force-pushed
the
export-D55218591
branch
from
eb5f14c to
63b1f75
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55218591 |
RSNara
force-pushed
the
export-D55218591
branch
from
63b1f75 to
0a1aec9
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55218591 |
RSNara
force-pushed
the
export-D55218591
branch
from
0a1aec9 to
f690484
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55218591 |
RSNara
force-pushed
the
export-D55218591
branch
from
f690484 to
0a3c260
Compare
RSNara
force-pushed
the
export-D55218591
branch
from
0a3c260 to
f618831
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55218591 |
Summary: Eventually, we will move all bridge methods to BridgeReactContext. Long-term, ReactApplicationContext and ReactContext will become abstract. And these two contexts will only contain methods common to both modes. Changelog: [Android][Added] Introduce BridgeReactContext Differential Revision: https://internalfb.com/D55218592
Summary: Eventaully, ReactApplicationContext.initailizeWithInstance() will be moved to BridgeReactContext. Doing the migration up-front to remove noise from the eventual diff. Changelog: [Internal] Differential Revision: https://internalfb.com/D55218593
…ext (facebook#43626) Summary: Pull Request resolved: facebook#43626 The things that create ReactApplicationContext should instead create BridgeReactContext. Long-term, ReactApplicationContext will be abstract. This diff pulls noise out from that eventual diff. Changelog: [Internal] Reviewed By: arushikesarwani94 Differential Revision: D55218591
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55218591 |
RSNara
force-pushed
the
export-D55218591
branch
from
f618831 to
4cc95ef
Compare
Contributor
|
This pull request has been merged in 8eb1bd1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The things that create ReactApplicationContext should instead create BridgeReactContext.
Long-term, ReactApplicationContext will be abstract. This diff pulls noise out from that eventual diff.
Changelog: [Internal]
Reviewed By: arushikesarwani94
Differential Revision: D55218591