Skip to content

Unbreak build_android in OSS#43803

Closed
arushikesarwani94 wants to merge 1 commit intofacebook:mainfrom
arushikesarwani94:export-D55664486
Closed

Unbreak build_android in OSS#43803
arushikesarwani94 wants to merge 1 commit intofacebook:mainfrom
arushikesarwani94:export-D55664486

Conversation

@arushikesarwani94
Copy link
Copy Markdown
Contributor

Summary:
The dependency resolution of java/com/facebook/soloader/annotation:annotation is missing in OSS and needs to be included in build.gradle.kts instead

Changelog: [Internal]

Differential Revision: D55664486

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 2, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D55664486

Summary:

The dependency resolution of java/com/facebook/soloader/annotation:annotation is missing in OSS and needs to be included in [build.gradle.kts](https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/build.gradle.kts) instead

Changelog: [Internal]

Differential Revision: D55664486
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D55664486

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 18,906,369 +8
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,275,018 +14
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 1252f63
Branch: main

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Apr 3, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in e70caee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants