chore: [TS] Transform TouchableOpacity from class to ForwardRef component#44030
Closed
retyui wants to merge 1 commit intofacebook:mainfrom
Closed
chore: [TS] Transform TouchableOpacity from class to ForwardRef component#44030retyui wants to merge 1 commit intofacebook:mainfrom
class to ForwardRef component#44030retyui wants to merge 1 commit intofacebook:mainfrom
Conversation
class to ForwardRef componentclass to ForwardRef component
581d814 to
c55b7c0
Compare
Contributor
|
@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@dmytrorykun merged this pull request in 3d00549. |
|
This pull request was successfully merged by @retyui in 3d00549. When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
If you check the source of truth
packages/react-native/Libraries/Components/Touchable/TouchableOpacity.jsI'll find thatTouchableOpacityis a result ofReact.forwardRef(...):react-native/packages/react-native/Libraries/Components/Touchable/TouchableOpacity.js
Lines 326 to 335 in f7eaf63
So the TS type isn't correct : (
Breaking changes
As
TouchableOpacityisn't class anymore it can't be used as value & typeRecommend solution: use build-in react type
React.ElementRefAlso, it possible to use
Viewas type:Changelog:
[GENERAL] [BREAKING] - [Typescript] Transform
TouchableOpacityfrom JSclasstoForwardRefcomponentTest Plan:
See:
packages/react-native/types/__typetests__/index.tsx