chore: [TS] Transform TouchableHighlight from class to ForwardRef component#44038
Closed
retyui wants to merge 1 commit intofacebook:mainfrom
Closed
chore: [TS] Transform TouchableHighlight from class to ForwardRef component#44038retyui wants to merge 1 commit intofacebook:mainfrom
TouchableHighlight from class to ForwardRef component#44038retyui wants to merge 1 commit intofacebook:mainfrom
Conversation
Contributor
|
@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@dmytrorykun merged this pull request in 401f2fb. |
|
This pull request was successfully merged by @retyui in 401f2fb. When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
If you check the source of truth
packages/react-native/Libraries/Components/Touchable/TouchableHighlight.jsI'll find thatTouchableHighlightis a result ofReact.forwardRef(...):react-native/packages/react-native/Libraries/Components/Touchable/TouchableHighlight.js
Lines 382 to 391 in 44d59ea
So the TS type isn't correct : (
Breaking changes
As
TouchableHighlightisn't class anymore it can't be used as value & typeRecommend solution: use build-in react type
React.ElementRefAlso, it possible to use
Viewas type:Changelog:
[GENERAL] [BREAKING] - [Typescript] Transform TouchableHighlight from JS class to ForwardRef component
Test Plan:
See:
packages/react-native/types/__typetests__/index.tsx