Internal API for Activity-less "Paused in debugger" overlay#44132
Closed
motiz88 wants to merge 5 commits intofacebook:mainfrom
Closed
Internal API for Activity-less "Paused in debugger" overlay#44132motiz88 wants to merge 5 commits intofacebook:mainfrom
motiz88 wants to merge 5 commits intofacebook:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56215119 |
Base commit: aa7a0bc |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56215119 |
motiz88
force-pushed
the
export-D56215119
branch
from
ad7ac44 to
e285bf9
Compare
Differential Revision: D56068445
Differential Revision: D56098084
Differential Revision: D56105051
Differential Revision: D56193523
…#44132) Summary: Pull Request resolved: facebook#44132 Changelog: [Breaking][Android] `DevSupportManagerFactory.create()` changed to take an additional parameter of type `PausedInDebuggerOverlayManager` (nullable) Enables integrators of React Native Android to supply their own implementation of the Fusebox "paused in debugger" overlay. This is primarily intended for legacy Meta-internal integrations that can't use the built-in implementation based on `Dialog`. **The API will likely go away once those integrations have been migrated.** Reviewed By: javache Differential Revision: D56215119
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56215119 |
motiz88
force-pushed
the
export-D56215119
branch
from
e285bf9 to
8743922
Compare
Contributor
|
This pull request has been merged in 1d26907. |
|
This pull request was successfully merged by @motiz88 in 1d26907. When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Enables integrators of React Native Android to supply their own implementation of the Fusebox "paused in debugger" overlay. This is primarily intended for legacy Meta-internal integrations that can't use the built-in implementation based on
Dialog. The API will likely go away once those integrations have been migrated.Differential Revision: D56215119